Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race condition in InstrumentsConcurrencyTests #100518

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Fix race condition in InstrumentsConcurrencyTests #100518

merged 2 commits into from
Oct 9, 2023

Conversation

thecoop
Copy link
Member

@thecoop thecoop commented Oct 9, 2023 •
edited
Loading

Fix a race condition between the two threads in InstrumentsConcurrencyTests. If the second thread gets the lock first, the test fails.

Fixes #100251

@thecoop thecoop added >bug :Core/Infra/Core Core issues without another label labels Oct 9, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine elasticsearchmachine added Team:Core/Infra Meta label for core/infra team v8.12.0 labels Oct 9, 2023
@elasticsearchmachine
Copy link
Collaborator

Hi @thecoop, I've created a changelog YAML for you.

@thecoop thecoop added the >test Issues or PRs that are addressing/adding tests label Oct 9, 2023
stu-elastic
stu-elastic approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@stu-elastic stu-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

@thecoop
Copy link
Member Author

thecoop commented Oct 9, 2023

@elasticmachine update branch

@thecoop thecoop added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Oct 9, 2023
@elasticsearchmachine elasticsearchmachine merged commit d81dbfa into elastic:main Oct 9, 2023
12 checks passed
@thecoop thecoop deleted the instruments-test-race branch October 9, 2023 15:57
thecoop added a commit to thecoop/elasticsearch that referenced this pull request Oct 11, 2023
@thecoop
Fix race condition in InstrumentsConcurrencyTests (elastic#100518)
27b29cf 
Fix a race condition between the two threads in
InstrumentsConcurrencyTests. If the second thread gets the lock first,
the test fails.

Fixes elastic#100251
@thecoop thecoop mentioned this pull request Oct 11, 2023
Merged
thecoop added a commit that referenced this pull request Oct 11, 2023
@thecoop
Backport InstrumentsConcurrencyTests fix to 8.11 (#100660)
1a683d1 
This backports #100518  to 8.11
Fixes #100251
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stu-elastic stu-elastic stu-elastic approved these changes

Assignees
No one assigned
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >bug :Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] InstrumentsConcurrencyTests testLockingWhenRegistering failing
4 participants
@thecoop @elasticsearchmachine @stu-elastic @elasticmachine